Skip to content

Add package of sapmachine-21#604

Open
Merlin-Xu-G wants to merge 3 commits into
ScoopInstaller:masterfrom
Merlin-Xu-G:feature/add-sapmachine-jdk-21
Open

Add package of sapmachine-21#604
Merlin-Xu-G wants to merge 3 commits into
ScoopInstaller:masterfrom
Merlin-Xu-G:feature/add-sapmachine-jdk-21

Conversation

@Merlin-Xu-G

@Merlin-Xu-G Merlin-Xu-G commented Jun 18, 2026

Copy link
Copy Markdown

Closes #603

@coderabbitai

coderabbitai Bot commented Jun 18, 2026 •
edited
Loading

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 2cdcfb3e-4c16-49fc-8122-75d7cefeea5a

📥 Commits

Reviewing files that changed from the base of the PR and between 6c3ce48 and bf2e771.

📒 Files selected for processing (1)
  • bucket/sapmachine21-jdk.json
💤 Files with no reviewable changes (1)
  • bucket/sapmachine21-jdk.json

Summary by CodeRabbit

  • New Features
    • Added SapMachine 21 JDK and JRE distributions (version 21.0.11)
    • Updated SapMachine LTS JDK and JRE to version 21.0.11

Walkthrough

The PR bumps the sapmachine-lts-jdk and sapmachine-lts-jre manifests from version 17.0.19 to 21.0.11, updating download URLs, SHA-256 hashes, extract directories, and checkver JSONPaths. It also adds two new version-pinned manifests, sapmachine21-jdk.json and sapmachine21-jre.json, each defining Windows x64 install metadata, environment wiring, and checkver/autoupdate rules.

Changes

SapMachine 21 Manifests

Layer / File(s) Summary
LTS JDK and JRE version bump to 21.0.11
bucket/sapmachine-lts-jdk.json, bucket/sapmachine-lts-jre.json		 Both LTS manifests replace version 17.0.19 with 21.0.11, updating the Windows x64 download URL, SHA-256 hash, extract_dir, and checkver jsonpath to the 21 release asset path.
New sapmachine21 JDK and JRE manifests
bucket/sapmachine21-jdk.json, bucket/sapmachine21-jre.json		 Introduces version-pinned manifests for SapMachine 21.0.11, each specifying release metadata, Windows x64 artifact URL and hash, extract_dir, env_add_path for bin, JAVA_HOME via env_set, and checkver/autoupdate rules using upstream release JSON with JSONPath, regex capture, and SHA-256 file matching.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Add package of sapmachine-21' directly describes the main change: adding SapMachine 21 packages (both JDK and JRE) to the bucket.
Description check ✅ Passed The description includes the required checkbox confirmation of reading the Contributing Guide and references the linked issue #603 with 'Closes' keyword, meeting template requirements.
Linked Issues check ✅ Passed The PR fully addresses issue #603 by adding both sapmachine-jdk21 and sapmachine-jre21 bucket manifests with correct download URLs, SHA-256 hashes, and version checking configuration.
Out of Scope Changes check ✅ Passed All changes are in-scope: updates to LTS versions (JDK/JRE 17→21) and addition of new SapMachine 21 packages directly address issue #603 requirements.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot]
coderabbitai Bot reviewed Jun 18, 2026
View reviewed changes

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: f5a798b9-e4fd-48ff-9907-2e2e25843fc3

📥 Commits

Reviewing files that changed from the base of the PR and between ca38e0d and 6c3ce48.

📒 Files selected for processing (4)
  • bucket/sapmachine-lts-jdk.json
  • bucket/sapmachine-lts-jre.json
  • bucket/sapmachine21-jdk .json
  • bucket/sapmachine21-jre.json

Comment thread bucket/sapmachine21-jdk.json
@Merlin-Xu-G Merlin-Xu-G mentioned this pull request Jun 18, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Request] Need a sapmachine-jdk21 package

1 participant

@Merlin-Xu-G